[PATCH] D149998: [test] [llvm-config] Assume unix style lib names on mingw targets

Alvin Wong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 01:37:58 PDT 2023


alvinhochun added a comment.

In D149998#4331540 <https://reviews.llvm.org/D149998#4331540>, @mstorsjo wrote:

> I guess `target` might be anything, for cases that are configured to cross compile by default, so we shouldn't rely on that in this test. I wonder if there's some similar feature we could check for the host instead of the target? Or perhaps we should just mark the windows part of the test `UNSUPPORTED: target={{.*-windows-gnu}}` and not complicate things more than necessary - that should be enough to achieve what we want here...

Seems that you may need to add a `lit.cfg.py` and check `config.host_triple` in there to set a custom feature keyword.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149998/new/

https://reviews.llvm.org/D149998



More information about the llvm-commits mailing list