[PATCH] D149998: [test] [llvm-config] Assume unix style lib names on mingw targets

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 23:56:21 PDT 2023


mstorsjo added a comment.

In D149998#4331023 <https://reviews.llvm.org/D149998#4331023>, @dyung wrote:

> Hi @mstorsjo, the change you made is causing the test llvm/test/tools/llvm-config/system-libs.test to fail on the PS5 Windows bot. Can you fix the test or revert if you need time to investigate?

Sorry about that, and sorry for not being around to revert it in a timely manner.

What's the `target` set to in the runs of this buildbot? I guess `target` might be anything, for cases that are configured to cross compile by default, so we shouldn't rely on that in this test. I wonder if there's some similar feature we could check for the host instead of the target? Or perhaps we should just mark the windows part of the test `UNSUPPORTED: target={{.*-windows-gnu}}` and not complicate things more than necessary - that should be enough to achieve what we want here...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149998/new/

https://reviews.llvm.org/D149998



More information about the llvm-commits mailing list