[PATCH] D149915: [CodeGen][KCFI] Move cfi-type lowering to TargetLowering

Tue May 9 21:05:04 PDT 2023

barannikov88 added inline comments.

================
Comment at: llvm/lib/CodeGen/KCFI.cpp:9
 //
-// This file implements KCFI indirect call checking.
+// This pass implements KCFI indirect call check lowering.
 //
----------------
samitolvanen wrote:
> samitolvanen wrote:
> > barannikov88 wrote:
> > > MaskRay wrote:
> > > > barannikov88 wrote:
> > > > > It is KFCI everywhere. At least in one place it should be explained what these four magical letters mean.
> > > > > File comment would be a good place.
> > > > > (I honestly have no idea about it, "kernel call frame information" is the first thing that comes to my mind.)
> > > > > 
> > > > CFI here means Control-flow integrity. This is an implementation that is dedicated to the Linux kernel
> > > > https://maskray.me/blog/2022-12-18-control-flow-integrity#fsanitizekcfi
> > > > 
> > > > (I need to do some homework that why this has a lot to do with codegen.)
> > > Thanks. I'll check out the blog post, too (nice blog btw, very informative).
> > > I still think the abbreviation needs to be explained in code. Or, better yet, what does this pass do.
> > > 
> > Good point. I'll expand this comment in a follow-up patch.
> https://reviews.llvm.org/rG9e869efc1b0a
Awesome, thank you

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149915/new/

https://reviews.llvm.org/D149915