[PATCH] D147964: [VPlan] Introduce new entry block to VPlan for early SCEV expansion.

Tue May 9 19:07:01 PDT 2023

manojgupta added a comment.

Just a heads up that this change most likely breaks Chrome when building with thinlto. The error happens at linking so it is hard for me to get a reproducer.
Error message if it can provide a hint:

  Instruction does not dominate all uses!
    %726 = sub i32 0, %559, !dbg !531
    %766 = insertelement <8 x i32> poison, i32 %726, i64 0, !dbg !531
  Instruction does not dominate all uses!
    %726 = sub i32 0, %559, !dbg !531
    %770 = mul i32 %726, 8, !dbg !531
  ld.lld: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:10495: bool llvm::LoopVectorizePass::processLoop(Loop *): Assertion `!verifyFunction(*L->getHeader()->getParent(), &dbgs())' failed.

The changelog from last passing to failing is:

$ git log --oneline a91cb9ce39dc42e6a7a2c4fe97580e51eb1c2961 <https://reviews.llvm.org/rGa91cb9ce39dc42e6a7a2c4fe97580e51eb1c2961>..30af2fb33ed2f610abfa50e53df9712887b2bd25 <https://reviews.llvm.org/rG30af2fb33ed2f610abfa50e53df9712887b2bd25> --  llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
e3afe0b89de5 <https://reviews.llvm.org/rGe3afe0b89de57662e411f8cc14f6229782ec86ff> [VPlan] Add VPWidenCastRecipe, split off from VPWidenRecipe (NFCI).
b85a402dd899 <https://reviews.llvm.org/rGb85a402dd899fc0e702a60b459bc06317d532d84> [VPlan] Introduce new entry block to VPlan for early SCEV expansion.
79692750d250 <https://reviews.llvm.org/rG79692750d250d2e155aaa2b078aeb0451f005cb6> [LV] Use VPValue for SCEV expansion in fixupIVUsers.
5362a0d859d8 <https://reviews.llvm.org/rG5362a0d859d8e96b3f7c0437b7866e17a818a4f7> [LCSSA] Remove unused ScalarEvolution argument (NFC)
6303fa369c85 <https://reviews.llvm.org/rG6303fa369c853466106d2140df92a494817840c3> [VPlan] Remove DeadInsts arg from VPInstructionsToVPRecipes (NFC)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147964/new/

https://reviews.llvm.org/D147964