[PATCH] D150029: [VPlan] Print IR flags for VPRecipeWithIRFlags.

[Ayal Zaks via Phabricator via llvm-commits]

Ayal added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1072
   }
+
+  FastMathFlags getFastMathFlags() const {
----------------
Also under #if as it's used only by printFlags()?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:597
+#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
+void VPRecipeWithIRFlags::printFlags(raw_ostream &O) const {
+  if (OpType == OperationType::PossiblyExactOp && ExactFlags.IsExact)
----------------
switch?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:599
+  if (OpType == OperationType::PossiblyExactOp && ExactFlags.IsExact)
+    O << " exact";
+  else if (OpType == OperationType::OverflowingBinOp) {
----------------
Thanks for covering the FMF cases!
Do "exact" and calls also miss test coverage?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150029/new/

https://reviews.llvm.org/D150029