[llvm] bcaa0b2 - PrologEpilogInserter: Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 13:29:26 PDT 2023


On Tue, May 9, 2023 at 4:24 PM Fangrui Song via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>
> Author: Fangrui Song
> Date: 2023-05-09T13:23:58-07:00
> New Revision: bcaa0b26aa7c39fc1403e1bb9c2c74f9e7ba704b
>
> URL: https://github.com/llvm/llvm-project/commit/bcaa0b26aa7c39fc1403e1bb9c2c74f9e7ba704b
> DIFF: https://github.com/llvm/llvm-project/commit/bcaa0b26aa7c39fc1403e1bb9c2c74f9e7ba704b.diff
>
> LOG: PrologEpilogInserter: Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds

Thank you for the quick fix, sorry for the hassle!

>
> Added:
>
>
> Modified:
>     llvm/lib/CodeGen/PrologEpilogInserter.cpp
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/llvm/lib/CodeGen/PrologEpilogInserter.cpp b/llvm/lib/CodeGen/PrologEpilogInserter.cpp
> index e68c30a0aff3..d69bf2f784d4 100644
> --- a/llvm/lib/CodeGen/PrologEpilogInserter.cpp
> +++ b/llvm/lib/CodeGen/PrologEpilogInserter.cpp
> @@ -309,18 +309,18 @@ bool PEI::runOnMachineFunction(MachineFunction &MF) {
>          SpillSize += MFI.getObjectSize(Idx);
>      }
>
> -    float SpillPct =
> +    [[maybe_unused]] float SpillPct =
>          static_cast<float>(SpillSize) / static_cast<float>(StackSize);
> -    float VarPct = 1.0f - SpillPct;
> -    int64_t VariableSize = StackSize - SpillSize;
> -    LLVM_DEBUG(dbgs() << formatv(
> -                   "{0}/{1} ({3:P}) spills, {2}/{1} ({4:P}) variables",
> -                   SpillSize, StackSize, VariableSize, SpillPct, VarPct));
> +    LLVM_DEBUG(
> +        dbgs() << formatv("{0}/{1} ({3:P}) spills, {2}/{1} ({4:P}) variables",
> +                          SpillSize, StackSize, StackSize - SpillSize, SpillPct,
> +                          1.0f - SpillPct));
>      if (UnsafeStackSize != 0) {
> -      float UnsafePct =
> -          static_cast<float>(UnsafeStackSize) / static_cast<float>(StackSize);
>        LLVM_DEBUG(dbgs() << formatv(", {0}/{2} ({1:P}) unsafe stack",
> -                                   UnsafeStackSize, UnsafePct, StackSize));
> +                                   UnsafeStackSize,
> +                                   static_cast<float>(UnsafeStackSize) /
> +                                       static_cast<float>(StackSize),
> +                                   StackSize));
>      }
>      LLVM_DEBUG(dbgs() << "\n");
>    }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list