[PATCH] D143018: [DAGCombiner][NFC] Factor out ByteProvider

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:21
 #include "llvm/ADT/ArrayRef.h"
+#include "llvm/ADT/ByteProvider.h"
 #include "llvm/ADT/DenseMap.h"
----------------
(Just being skeptical.)
IMHO the implementation is not that abstract to be put into ADT.
Comments and names suggest that it has relation to instruction selection.
Keeping it to SelectionDAG/TargetLowering/CodeGen would make the SFINAE redundant, too.
Is it going to be used for anything other than SDValue anyway?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143018/new/

https://reviews.llvm.org/D143018