[PATCH] D147957: [FS-AFDO] Generate pseudo-probe-based profiles with FS-discriminators.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/include/llvm/MC/MCPseudoProbe.h:132
 
+  uint64_t getFSDiscriminator() const { return FSDiscriminator; }
+
----------------
wenlei wrote:
> nit: this should be moved to the previous patch
Done.


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:1179
+        assert(!CallerDiscriminator &&
+               "Callsite probe should not have a discriminator!");
         FunctionSamples &CallerProfile =
----------------
wenlei wrote:
> This is because we used discriminator of call to hold call probe id, so we have no place for actual discriminator, right? 
Exactly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147957/new/

https://reviews.llvm.org/D147957