[PATCH] D150210: [CodeGenPrepare] Fix for using outdated/corrupt LoopInfo

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 10:40:30 PDT 2023


chill created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
chill requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Some transformation in CodeGenPrepare pass may create and/or delete
basic block, but they don't update the LoopInfo, so the LoopInfo may
end up containing dangling pointers and sometimes reused basic blocks,
which leads to "interesting" non-deterministic behaviour.

This patch makes the pass invalidate the LoopInfo whenever the
DominationTree is invalidated and lazily rebuilds it.


https://reviews.llvm.org/D150210

Files:
  llvm/lib/CodeGen/CodeGenPrepare.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150210.520753.patch
Type: text/x-patch
Size: 11893 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230509/5d93ab70/attachment.bin>


More information about the llvm-commits mailing list