[PATCH] D150142: [InstCombine] Add simplifications for div/rem with `i1` operands; PR62607

Zhu Siyuan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 09:10:57 PDT 2023


floatshadow added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:1097
   // We don't need to preserve faults!
   if (match(Op1, m_Zero()))
     return PoisonValue::get(Ty);
----------------
Can we remove this? I think this might also be covered by `KnownBits::isZero()` check now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150142/new/

https://reviews.llvm.org/D150142



More information about the llvm-commits mailing list