[PATCH] D149938: [AMDGPU][InferAddressSpaces] Only rewrite address-spaces that can be trivially casted to flat for llvm.amdgcn.flat.atomic.{fadd,fmax,fmin}

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 08:57:09 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/test/Transforms/InferAddressSpaces/AMDGPU/flat-fadd-fmin-fmax-intrinsics.ll:166
+  ret void
+}
----------------
arsenm wrote:
> Add a test with a random number, other unknown address spaces should generally act like global.
> 
> Also test the new fat pointer address spaces?
Also constant 32 bit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149938/new/

https://reviews.llvm.org/D149938



More information about the llvm-commits mailing list