[PATCH] D150011: AMDGPU: Pattern match fract instructions in AMDGPUCodeGenPrepare

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 08:38:33 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp:228
+  Value *matchFractPat(IntrinsicInst &I);
+  Value *applyFractPat(IRBuilder<> &Builder, Value *FractArg);
+
----------------
Pierre-vh wrote:
> nit: isn't `IRBuilderBase` better?
> 
Don't see the point of making the type name longer here, it's not going to use any other IRBuilder


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150011/new/

https://reviews.llvm.org/D150011



More information about the llvm-commits mailing list