[PATCH] D150198: AIX traceback functionality

Chris Bowler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 07:38:12 PDT 2023


cebowleratibm added inline comments.


================
Comment at: llvm/lib/Support/Unix/Signals.inc:88
 
+#if defined(_AIX)
+static void
----------------
I generally dislike seeing #if defined(_AIX) dispersed throughout the source.  

If AIX is the only host that uses IsKillWithContext, that's fine.  I don't think you need to #if as much as you do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150198/new/

https://reviews.llvm.org/D150198



More information about the llvm-commits mailing list