[PATCH] D150074: InstCombine: Handle shrinking fneg used by fptrunc

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 07:34:49 PDT 2023


foad added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp:1744
 
   // (fptrunc (fneg x)) -> (fneg (fptrunc x))
   Value *X;
----------------
This comment seems misplaced.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp:1753
 
     if (match(Op, m_FNeg(m_Value(X)))) {
       Value *InnerTrunc = Builder.CreateFPTrunc(X, Ty);
----------------
Now I'm confused. What does this code handle and how is it different from what you added?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150074/new/

https://reviews.llvm.org/D150074



More information about the llvm-commits mailing list