[PATCH] D149294: Do not optimize debug locations across section boundaries

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Sorry I haven't been keeping up, but I have a suggestion for the test.



================
Comment at: llvm/test/DebugInfo/X86/basic-block-sections-debug-lineinfo-at-section-boundary.ll:17
+;
+; CHECK-COUNT-2: .loc    0 4 1
+
----------------
This shows there are two .loc directives, but not that they are in different sections. I know I've seen redundant .loc directives  and we even have a downstream patch to filter them out, so I think it would be good for this test to at least verify there's a .section directive between the two .loc directives.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149294/new/

https://reviews.llvm.org/D149294