[PATCH] D150097: [DAGCombiner] Add tests for `computeKnownBits` of `sdiv` and `udiv`; NFC

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 19:58:00 PDT 2023


goldstein.w.n updated this revision to Diff 520566.
goldstein.w.n added a comment.

Update tests. Causes regression in ARM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150097/new/

https://reviews.llvm.org/D150097

Files:
  llvm/test/CodeGen/X86/knownbits-div.ll


Index: llvm/test/CodeGen/X86/knownbits-div.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/X86/knownbits-div.ll
@@ -0,0 +1,82 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-unknown | FileCheck %s
+
+define i8 @sdiv_neg_neg_high_bits(i8 %x, i8 %y) {
+; CHECK-LABEL: sdiv_neg_neg_high_bits:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    orb $-128, %dil
+; CHECK-NEXT:    orb $-125, %sil
+; CHECK-NEXT:    movsbl %dil, %eax
+; CHECK-NEXT:    idivb %sil
+; CHECK-NEXT:    andb $-128, %al
+; CHECK-NEXT:    retq
+  %num = or i8 %x, 128
+  %denum = or i8 %y, 131
+  %div = sdiv i8 %num, %denum
+  %r = and i8 %div, 128
+  ret i8 %r
+}
+
+define i8 @sdiv_exact_odd_odd(i8 %x, i8 %y) {
+; CHECK-LABEL: sdiv_exact_odd_odd:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    orb $1, %dil
+; CHECK-NEXT:    orb $1, %sil
+; CHECK-NEXT:    movsbl %dil, %eax
+; CHECK-NEXT:    idivb %sil
+; CHECK-NEXT:    andb $1, %al
+; CHECK-NEXT:    retq
+  %num = or i8 %x, 1
+  %denum = or i8 %y, 1
+  %div = sdiv exact i8 %num, %denum
+  %r = and i8 %div, 1
+  ret i8 %r
+}
+
+define i8 @sdiv_exact_even_even_fail_unknown(i8 %x, i8 %y) {
+; CHECK-LABEL: sdiv_exact_even_even_fail_unknown:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    andb $-2, %dil
+; CHECK-NEXT:    andb $-2, %sil
+; CHECK-NEXT:    movsbl %dil, %eax
+; CHECK-NEXT:    idivb %sil
+; CHECK-NEXT:    andb $1, %al
+; CHECK-NEXT:    retq
+  %num = and i8 %x, -2
+  %denum = and i8 %y, -2
+  %div = sdiv exact i8 %num, %denum
+  %r = and i8 %div, 1
+  ret i8 %r
+}
+
+define i8 @udiv_exact_even_odd(i8 %x, i8 %y) {
+; CHECK-LABEL: udiv_exact_even_odd:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    andb $-2, %dil
+; CHECK-NEXT:    orb $1, %sil
+; CHECK-NEXT:    movzbl %dil, %eax
+; CHECK-NEXT:    divb %sil
+; CHECK-NEXT:    andb $1, %al
+; CHECK-NEXT:    retq
+  %num = and i8 %x, -2
+  %denum = or i8 %y, 1
+  %div = udiv exact i8 %num, %denum
+  %r = and i8 %div, 1
+  ret i8 %r
+}
+
+define i8 @udiv_exact_even_even_fail_unknown(i8 %x, i8 %y) {
+; CHECK-LABEL: udiv_exact_even_even_fail_unknown:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    andb $-2, %dil
+; CHECK-NEXT:    andb $-2, %sil
+; CHECK-NEXT:    movzbl %dil, %eax
+; CHECK-NEXT:    divb %sil
+; CHECK-NEXT:    andb $1, %al
+; CHECK-NEXT:    retq
+  %num = and i8 %x, -2
+  %denum = and i8 %y, -2
+  %div = udiv exact i8 %num, %denum
+  %r = and i8 %div, 1
+  ret i8 %r
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150097.520566.patch
Type: text/x-patch
Size: 2485 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230509/927046d8/attachment.bin>


More information about the llvm-commits mailing list