[PATCH] D150167: [BOLT][DWARF][NFC] Fixed an assertion check

Alexander Yermolovich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 18:11:25 PDT 2023


ayermolo created this revision.
Herald added subscribers: treapster, hoy, modimo, wenlei.
Herald added a reviewer: rafauler.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
ayermolo requested review of this revision.
Herald added subscribers: llvm-commits, yota9.
Herald added a project: LLVM.

Spotted this one while working on new DWARF Rewriter. We were using wrong check
in assertion.

Test Plan:


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150167

Files:
  bolt/lib/Rewrite/DWARFRewriter.cpp


Index: bolt/lib/Rewrite/DWARFRewriter.cpp
===================================================================
--- bolt/lib/Rewrite/DWARFRewriter.cpp
+++ bolt/lib/Rewrite/DWARFRewriter.cpp
@@ -199,7 +199,7 @@
           std::make_unique<DebugLoclistWriter>(*CU.get(), DwarfVersion, false);
 
       if (std::optional<uint64_t> DWOId = CU->getDWOId()) {
-        assert(LocListWritersByCU.count(*DWOId) == 0 &&
+        assert(RangeListsWritersByCU.count(*DWOId) == 0 &&
                "RangeLists writer for DWO unit already exists.");
         auto RangeListsSectionWriter =
             std::make_unique<DebugRangeListsSectionWriter>();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150167.520544.patch
Type: text/x-patch
Size: 639 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230509/8b5e45b0/attachment.bin>


More information about the llvm-commits mailing list