[PATCH] D147651: [PseudoProbe] Encode/Decode FS discriminator

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/include/llvm/IR/PseudoProbe.h:34
+  Sentinel = 0x2,           // A place holder for split function entry address.
+  HasFSDiscriminator = 0x4, // for probes with a FS discriminator
 };
----------------
At this layer, there's nothing specific to FS. I think we can just call it HasDiscriminator. This is essentially discriminator to probe, and we just currently use it for FSDiscriminator. 

Then s/FSDiscriminator/Discriminator/g for this entire patch. 


================
Comment at: llvm/include/llvm/MC/MCPseudoProbe.h:114
   uint64_t Index;
+  uint64_t FSDiscriminator;
   uint8_t Attributes;
----------------
can we use 32bit here? 


================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:2349
+  OS << "\t.pseudoprobe\t" << Guid << " " << Index << " " << Type << " " << Attr
+     << " " << FSDiscriminator;
   // Emit inline stack like
----------------
should we skip if disc is 0, meaning no disc? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147651/new/

https://reviews.llvm.org/D147651