[PATCH] D150144: cmake: add missing dependency on Attributes.inc

Jon Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 15:32:00 PDT 2023


jroelofs updated this revision to Diff 520490.
jroelofs added a comment.

@bulbazord and I talked offline. It's simpler to keep Attributes.inc under the `intrinsics_gen` target


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150144/new/

https://reviews.llvm.org/D150144

Files:
  llvm/unittests/Analysis/CMakeLists.txt
  llvm/utils/TableGen/CMakeLists.txt


Index: llvm/utils/TableGen/CMakeLists.txt
===================================================================
--- llvm/utils/TableGen/CMakeLists.txt
+++ llvm/utils/TableGen/CMakeLists.txt
@@ -86,6 +86,9 @@
   X86RecognizableInstr.cpp
   WebAssemblyDisassemblerEmitter.cpp
   $<TARGET_OBJECTS:obj.LLVMTableGenCommon>
+
+  DEPENDS
+  intrinsics_gen # via llvm-min-tablegen
   )
 target_link_libraries(llvm-tblgen PRIVATE LLVMTableGenGlobalISel)
 set_target_properties(llvm-tblgen PROPERTIES FOLDER "Tablegenning")
Index: llvm/unittests/Analysis/CMakeLists.txt
===================================================================
--- llvm/unittests/Analysis/CMakeLists.txt
+++ llvm/unittests/Analysis/CMakeLists.txt
@@ -64,6 +64,8 @@
   ${ANALYSIS_TEST_SOURCES}
   )
 
+add_dependencies(AnalysisTests intrinsics_gen)
+
 target_link_libraries(AnalysisTests PRIVATE LLVMTestingSupport)
 
 # On AIX, enable run-time linking to allow symbols from the plugins shared


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150144.520490.patch
Type: text/x-patch
Size: 958 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230508/19c98ab3/attachment.bin>


More information about the llvm-commits mailing list