[PATCH] D149635: [libunwind] include alloca.h in config.h

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 11:37:33 PDT 2023


compnerd added inline comments.


================
Comment at: libunwind/src/config.h:129
     defined(_LIBUNWIND_IS_BAREMETAL)
 #define _LIBUNWIND_REMEMBER_ALLOC(_size) alloca(_size)
 #define _LIBUNWIND_REMEMBER_FREE(_ptr)                                         \
----------------
danielkiss wrote:
> alloca.h is needed for this so probably the simplest way is just to build with `_LIBUNWIND_REMEMBER_HEAP_ALLOC` if that causes trouble for you.
Sure, that makes sense, but the inclusion of the header should be guarded by `_LIBUNWIND_REMEMBER_HEAP_ALLOC` then right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149635/new/

https://reviews.llvm.org/D149635



More information about the llvm-commits mailing list