[PATCH] D138526: [SimpleLoopUnswitch] unswitch selects

Mon May 8 10:16:15 PDT 2023

vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

Thanks.
Freeze is going to be false negatives, which are bad for msan, but better then false positives. Taking that this is -O3 only the patch is LGTM.

I played with existing version of compiler, looks like freeze from this pass can hide a lot of bugs.
So please consider just make this patch NOOP if function has sanitize_memory attribute.  Do you see disadvantages in this?

BTW. Also this probably means that we need to switch our msan bots to -O2 or below, to catch more uninit bugs in LLVM.

> Would appreciate review on wording for these.

This is beyond my expertise.  I'll accept, but please set a blocking reviewer to catch attention of particular person.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138526/new/

https://reviews.llvm.org/D138526