[PATCH] D141188: [MergeICmps] Adapt to non-eq comparisons

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 10:06:29 PDT 2023


aeubanks added a comment.

In D141188#4320968 <https://reviews.llvm.org/D141188#4320968>, @aeubanks wrote:

> In D141188#4320794 <https://reviews.llvm.org/D141188#4320794>, @Allen wrote:
>
>> hi @aeubanks, as the discussion on https://reviews.llvm.org/D149542, the miscompile (https://alive2.llvm.org/ce/z/Zr5dfP) doesn't need to be handled ?
>
> hmm I swear the miscompile I was seeing wasn't related to poison/freeze, it was similar to the previous miscompile where it was just a wrong true/false. I'll take a look again

I didn't see an issue reapplying this patch on the test case I was looking at so I've relanded it, sorry for the trouble


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141188/new/

https://reviews.llvm.org/D141188



More information about the llvm-commits mailing list