[PATCH] D134129: [PATCH] [RISCV] Enable -msave-restore by default when optimizing for size

Mon May 8 09:56:46 PDT 2023

hiraditya added a subscriber: paulkirth.
hiraditya added a comment.

In D134129#4326819 <https://reviews.llvm.org/D134129#4326819>, @craig.topper wrote:

> In D134129#4326811 <https://reviews.llvm.org/D134129#4326811>, @hiraditya wrote:
>
>> In D134129#4191314 <https://reviews.llvm.org/D134129#4191314>, @craig.topper wrote:
>>
>>> Would this break shadow call stack which isn't compatible with save/restore lib calls? Or do we already check that somewhere?
>>
>> Will this still be the issue when X3 will be used for SCS?
>
> I don't think so as long as the error about mixing -msave-restore with SCS was removed from RISCVFrameLowering.cpp when we switched to X3.

Seems like https://reviews.llvm.org/D149099 fixed it? cc: @paulkirth for confirmation.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134129/new/

https://reviews.llvm.org/D134129