[PATCH] D149815: [OpenMP][Flang][Semantics] Add semantics support for USE_DEVICE_ADDR clause on OMP TARGET DATA directive.

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:520
+      Symbol::Flag::OmpCopyIn, Symbol::Flag::OmpUseDevicePtr,
+      Symbol::Flag::OmpUseDeviceAddr};
 
----------------
What is the plan here? I mean do you plan to use these flags in the lowering somehow or do you just replicate what was done for other clauses?


================
Comment at: flang/test/Semantics/OpenMP/use_device_ptr.f90:15
    !$omp target data map(tofrom: a, arrayB) use_device_ptr(b)
-   !CHECK: b (OmpUseDevicePtr)
+   !CHECK: b (OmpUseDevicePtr): HostAssoc
       allocate(arrayB)
----------------
raghavendhra wrote:
> clementval wrote:
> > This change seems related to `use_device_ptr`
> Yes, I missed this additional check in previous commit so adding it here. Is that okay?
It might be better to do it in a separate patch since it is unrelated to this one. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149815/new/

https://reviews.llvm.org/D149815