[PATCH] D149993: [SLP][NFC] Cleanup: Separate vectorization of Inserts and CmpInsts.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 06:35:37 PDT 2023


ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:14639-14641
+    return (isa<InsertElementInst, InsertValueInst>(I) &&
+            PostProcessInserts.contains(I)) ||
+           (isa<CmpInst>(I) && PostProcessCmps.contains(cast<CmpInst>(I)));
----------------
Use dyn_cast:
```
if (auto *Cmp = dyn_cast<CmpInst>(I))
  return PostProcessCmps.contains(Cmp);
return isa<InsertElementInst, InsertValueInst>(I) && PostProcessInserts.contains(I);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149993/new/

https://reviews.llvm.org/D149993



More information about the llvm-commits mailing list