[PATCH] D149082: [VPlan] Use VPIRFlags for VPWidenGEPRecipe (NFCI).
Ayal Zaks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 8 04:52:38 PDT 2023
Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of minor nits.
================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:945-946
PossiblyExactOp,
FPMathOp,
+ GEPOp,
Other
----------------
Just to be consistent, GEP is introduced between Exact and FMF in all that follows.
================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:838
auto *NewGEP = State.Builder.CreateGEP(GEP->getSourceElementType(), Ptr,
- Indices, "", IsInBounds);
+ Indices, "");
+ if (auto *I = dyn_cast<GetElementPtrInst>(NewGEP))
----------------
Simpler in this case to pass GEPFlags.IsInBounds to CreateGEP()?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149082/new/
https://reviews.llvm.org/D149082
More information about the llvm-commits
mailing list