[PATCH] D150100: [KnownBits] Improve implementation of `KnownBits::abs`

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Support/KnownBits.cpp:404
+  unsigned Max = countMaxTrailingZeros();
+  unsigned Min = countMinTrailingZeros();
+
----------------
Maybe call these MaxTZ/MinTZ? Just to make it clear later on we're not talking about the possible min/max values


================
Comment at: llvm/lib/Support/KnownBits.cpp:430
+  }
   return KnownAbs;
 }
----------------
Worth adding a assert(!KnownAbs.hasConflict() && "KnownBits conflict!"); ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150100/new/

https://reviews.llvm.org/D150100