[PATCH] D150107: [X86] Remove patterns for shift/rotate with immediate 1 and update side effect

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 03:19:00 PDT 2023


skan created this revision.
Herald added subscribers: lebedev.ri, pengfei, gbedwell, hiraditya.
Herald added a reviewer: andreadb.
Herald added a reviewer: lebedev.ri.
Herald added a reviewer: lebedev.ri.
Herald added a project: All.
skan requested review of this revision.
Herald added subscribers: llvm-commits, StephenFan.
Herald added a project: LLVM.

1. Do encoding optimization during MC lowering so that we can drop the patterns for shift/rotate with immediate 1
2. Set mayLoad = 1 for shift/rotate with a memory operand


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150107

Files:
  llvm/lib/Target/X86/X86InstrShiftRotate.td
  llvm/lib/Target/X86/X86MCInstLower.cpp
  llvm/test/CodeGen/X86/GlobalISel/ashr-scalar.ll
  llvm/test/CodeGen/X86/GlobalISel/lshr-scalar.ll
  llvm/test/CodeGen/X86/GlobalISel/select-ashr-scalar.mir
  llvm/test/CodeGen/X86/GlobalISel/select-lshr-scalar.mir
  llvm/test/CodeGen/X86/fast-isel-shift.ll
  llvm/test/CodeGen/X86/gpr-to-mask.ll
  llvm/test/CodeGen/X86/is_fpclass.ll
  llvm/test/tools/llvm-mca/X86/AlderlakeP/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/Atom/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/Barcelona/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/BdVer2/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/Broadwell/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/BtVer2/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/Generic/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/Haswell/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/IceLakeServer/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/SLM/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/SandyBridge/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/SkylakeClient/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/SkylakeServer/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/Znver1/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/Znver2/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/Znver3/resources-x86_64.s
  llvm/test/tools/llvm-mca/X86/Znver4/resources-x86_64.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150107.520315.patch
Type: text/x-patch
Size: 126276 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230508/39b563d8/attachment.bin>


More information about the llvm-commits mailing list