[PATCH] D149855: [DAGCombiner] Avoid template for generalized pattern match.

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

> There is a concern that using template for many functions in
> DAGCombiner.cpp may make the binary too large.

Could you provide more details on this concern, eg where was it raised? To put this discussion in perspective, looking at vanilla LLVM 14, a debug build of `DAGCombiner.cpp.o` has `7MB` vs `1322MB` for `libLLVM-14.so` (with `X86`,`RISCV`). I would add that this approach adds virtual dispatch on the standard DAGCombiner path, which has a performance cost. IMHO, the question is what a good tradeoff would be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149855/new/

https://reviews.llvm.org/D149855