[PATCH] D150105: [AMDGPU] Recompute liveness in SIOptimizeExecMaskingPreRA

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 00:31:25 PDT 2023


Pierre-vh created this revision.
Pierre-vh added reviewers: arsenm, foad, critson.
Herald added subscribers: StephenFan, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
Pierre-vh requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Instead of ad-hoc updating liveness, recompute it completely for the affected register.

This does not affect any existing test and fixes an edge case that
caused a "Non-empty but used interval" error in the register allocator
due to how the pass updated liveranges. It created a "isolated" live-through
segment.

Overall this change just seems to be a net positive with no side effect observed. There may be a compile time impact but it's expected to be minimal.

Fixes SWDEV-388279


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150105

Files:
  llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp
  llvm/test/CodeGen/AMDGPU/optimize-exec-mask-pre-ra-non-empty-but-used-interval.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150105.520284.patch
Type: text/x-patch
Size: 10207 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230508/bc915684/attachment.bin>


More information about the llvm-commits mailing list