[PATCH] D150049: [RISCV] Simplify matchRegisterNameHelper interface. NFC
Sergei Barannikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 8 00:00:30 PDT 2023
barannikov88 added inline comments.
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1478
+ RegNo = matchRegisterNameHelper(isRVE(), Name);
+ if (!RegNo.isValid())
return MatchOperand_NoMatch;
----------------
craig.topper wrote:
> barannikov88 wrote:
> > Just `if (!RegNo)`?
> >
> Isn't that relying on the `operator unsigned` that's supposed to get removed from MCRegister eventually?
It does currently, but I think adding `explicit operator bool() const` to `MCRegister` should be fine?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150049/new/
https://reviews.llvm.org/D150049
More information about the llvm-commits
mailing list