[PATCH] D150049: [RISCV] Simplify matchRegisterNameHelper interface. NFC

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 7 23:58:34 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1478
+  RegNo = matchRegisterNameHelper(isRVE(), Name);
+  if (!RegNo.isValid())
     return MatchOperand_NoMatch;
----------------
barannikov88 wrote:
> Just `if (!RegNo)`?
> 
Isn't that relying on the `operator unsigned` that's supposed to get removed from MCRegister eventually?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150049/new/

https://reviews.llvm.org/D150049



More information about the llvm-commits mailing list