[PATCH] D146872: [1/11][IR] Permit load/store/alloca for struct of the same scalable vector type

Yueh-Ting (eop) Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 7 23:57:40 PDT 2023


eopXD added inline comments.


================
Comment at: llvm/lib/IR/Type.cpp:635
+      return false;
+    if (StructType *STy = dyn_cast<StructType>(Ty);
+        STy && containsHomogeneousScalableVectorTypes())
----------------
craig.topper wrote:
> Doesn't checking isScalableTy() make this unnecessary?
Yes you are correct. Furthermore calling `isScalableTy` uncovered a bug that I forgot to record visited `Type` that would result in infinite loop case for recursively-defined types.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146872/new/

https://reviews.llvm.org/D146872



More information about the llvm-commits mailing list