[PATCH] D149058: [BPF][DebugInfo] Use .BPF.ext for line info when DWARF is not available

Yonghong Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 7 22:27:16 PDT 2023


yonghong-song accepted this revision.
yonghong-song added a comment.
This revision is now accepted and ready to land.

>From BPF perspective, it looks good to me. The only thing I am not sure is in struct DILineInfo, `std::optional<StringRef> LineSource;` is added which sounds a little bit weird since 'Source' is there. But the 'LineSource' is used to differentiate from dwarf 'Source'. If this is not preferred, we could remove it and hide the LineSource info in BTFContext instead.

@MaskRay @jhenderson I really appreciate your opinions on this BTF addition to llvm-objdump. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149058/new/

https://reviews.llvm.org/D149058



More information about the llvm-commits mailing list