[PATCH] D150068: [X86][AsmParser] Refactor code in AsmParser

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 7 21:18:22 PDT 2023


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM with that comment.



================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86EncodingOptimization.cpp:67
+    return false;
+  MCOperand &LastOp = MI.getOperand(NumOps - 1);
+  unsigned NewOpc;
----------------
This can be moved below the switch and then you wouldn't need to check how many operands there are.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150068/new/

https://reviews.llvm.org/D150068



More information about the llvm-commits mailing list