[PATCH] D150068: [X86][AsmParser] Refactor code in AsmParser

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86InstrOptimization.cpp:54
+
+bool X86::optimizeShiftRotateWithImmediateOne(MCInst &MI) {
+  auto E = MI.end();
----------------
Not for this patch, but should we use this in X86MCInstLower and remove all the isel patterns that select the 1 immediate version?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150068/new/

https://reviews.llvm.org/D150068