[PATCH] D149783: [DAGCombiner] Add bswap(logic_op(bswap(x), y)) optimization

Austin Chang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 7 09:59:41 PDT 2023


austin880625 added a comment.

@goldstein.w.n Sorry I downloaded the raw patch and compared with my `git diff` one without finding actual difference. Might need more clarification on how to confirm "not based on the version of D149782 <https://reviews.llvm.org/D149782>"

>From the diff with previous patch <https://reviews.llvm.org/D149783?vs=519966&id=520122#toc> the `bs_xor_rhs_brev32` test case was removed in the diff context, so I thought it should be based on the new test cases alr? However the test cases in ARM backend only contains negative tests so they have no diff in this patch, maybe I should also copy some positive ones from x86.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149783/new/

https://reviews.llvm.org/D149783



More information about the llvm-commits mailing list