[PATCH] D149783: [DAGCombiner] Add bswap(logic_op(bswap(x), y)) optimization

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 7 08:35:49 PDT 2023


goldstein.w.n added a comment.

In D149783#4325160 <https://reviews.llvm.org/D149783#4325160>, @austin880625 wrote:

> oh by rebase onto `main` I mean I rebased the two commit(for D149782 <https://reviews.llvm.org/D149782> and for D149783 <https://reviews.llvm.org/D149783>) in my branch onto the `main` branch together, so this patch is still based on the commit for D149782 <https://reviews.llvm.org/D149782>. For clarity these are the commands I used:
>
>   git diff main HEAD~ -U999999 > ../62236-DAG-test.patch #for D149782, based on previously pulled main branch
>   git diff HEAD~ HEAD -U999999 > ../62236-DAG-impl.patch #for this D149783

The issue is that you updated purely D149782 <https://reviews.llvm.org/D149782> with the new tests, but the current version of D149783 <https://reviews.llvm.org/D149783> is not based on the version of D149782 <https://reviews.llvm.org/D149782> with the new tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149783/new/

https://reviews.llvm.org/D149783



More information about the llvm-commits mailing list