[PATCH] D149864: [M68k] Add new calling convention M68k_RTD

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 7 06:43:02 PDT 2023


jrtc27 added a comment.

You need a test for calling a variadic function which, by my reading of GCC's manage and comparing it to X86, should be unaffected



================
Comment at: llvm/test/CodeGen/M68k/CConv/rtd-call.ll:1
+; RUN: llc -mtriple=m68k %s -stop-after=finalize-isel -o - | FileCheck %s
+
----------------
I don't know if the M68k backend tests do this as religiously as RISCV, but you should probably be using update_mir_test_checks.py for your MIR output tests.


================
Comment at: llvm/test/CodeGen/M68k/CConv/rtd-ret.ll:6
+; CHECK-LABEL: ret:
+; CHECK:         .cfi_startproc
+; CHECK-NEXT:  ; %bb.0: ; %entry
----------------
nounwind?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149864/new/

https://reviews.llvm.org/D149864



More information about the llvm-commits mailing list