[PATCH] D128011: [SimplifyLibCalls] Transform memchr(STR, C, N) to chain of ORs

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 7 04:16:06 PDT 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:1395
+  if (!DL.fitsInLegalInteger(Max + 1)) {
+    // Build chain of logical ORs
+    // Transform:
----------------
Drop "logical". The or is not logical in the sense we use the word.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:1408
+        }
+    }
+
----------------
clang-format. The indentation is wrong here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128011/new/

https://reviews.llvm.org/D128011



More information about the llvm-commits mailing list