[PATCH] D148947: [MemRefToLLVM] Add a method in MemRefDescriptor to get the buffer addr

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp:211
+  // Skip if offset is zero.
+  if (offsetCst != 0) {
+    Type indexType = converter.getIndexType();
----------------
nit: can we turn this into an early exit?

```
if (offsetCst == 0)
  return ptr;

...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148947/new/

https://reviews.llvm.org/D148947