[PATCH] D149698: [IntervalTree] Initialize find_iterator::Point

[Joshua Cao via Phabricator via llvm-commits]

caojoshua updated this revision to Diff 520147.
caojoshua retitled this revision from "[IntervalTree] Initialize find_iterator::Point with default constructor" to "[IntervalTree] Initialize find_iterator::Point".
caojoshua edited the summary of this revision.
caojoshua added a comment.

- zero initialize Point
- update commit message to show this is NFC. there is no true use-of-uninitialized bug in IntervalTree, just a bug in the unswitching patch

I don't want to push this until https://reviews.llvm.org/D138526 is merged and is not causing any test issues. I fixed that patch to pass the affected test locally, but want to confirm on buildbot builds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149698/new/

https://reviews.llvm.org/D149698

Files:
  llvm/include/llvm/ADT/IntervalTree.h


Index: llvm/include/llvm/ADT/IntervalTree.h
===================================================================
--- llvm/include/llvm/ADT/IntervalTree.h
+++ llvm/include/llvm/ADT/IntervalTree.h
@@ -463,7 +463,7 @@
     // Current node and index while traversing the intervals that contain
     // the reference point.
     IntervalNode *Node = nullptr;
-    PointType Point;
+    PointType Point = {};
     unsigned Index = 0;
 
     // For the current node, check if we have intervals that contain the


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149698.520147.patch
Type: text/x-patch
Size: 503 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230507/0251a528/attachment.bin>