[PATCH] D150047: [X86][CodeGen] Do not add `offset` for memory reference using symbol

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: llvm/test/CodeGen/X86/ms-inline-asm-functions.ll:1
+; RUN: llc -no-integrated-as < %s | FileCheck %s
+
----------------
Add a comment ``;; Check that the generated memory references do not contain the `offset` operator. Use -no-integrated-as to disable AsmParser formatting.``


================
Comment at: llvm/test/CodeGen/X86/ms-inline-asm-functions.ll:3
+
+; This file was compiled from clang/test/CodeGen/ms-inline-asm-functions.c,
+; using the following command line:
----------------
`;;` for non-CHECK non-RUN lines. This marker may help (future) auto tools to retain the comments.


================
Comment at: llvm/test/CodeGen/X86/ms-inline-asm-functions.ll:93
+attributes #0 = { noinline nounwind optnone "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-features"="+cx8,+x87" }
+attributes #1 = { "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-features"="+cx8,+x87" }
+attributes #2 = { naked noinline nounwind optnone "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-features"="+cx8,+x87" }
----------------
Clean up unneeded attributes and metadata to reduce noise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150047/new/

https://reviews.llvm.org/D150047