[PATCH] D149848: [AArch64, compiler-rt] Implement trampoline intrinsics

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added inline comments.


================
Comment at: compiler-rt/lib/builtins/trampoline_setup.c:45
+
+#if defined(__aarch64__) && !defined(__ANDROID__) && !defined(__APPLE__)
+static __inline void aarch64_gen_constant(uint32_t *buf, uint64_t constant,
----------------
Does this apply to Windows?  I think that the condition here is incorrect.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:5772
+    report_fatal_error("trampoline intrinsics are "
+                       "not supported on this platform.");
+
----------------
This will emit this on Windows as well, is this supposed to work there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149848/new/

https://reviews.llvm.org/D149848