[PATCH] D149699: [InstCombine] Improve bswap optimization

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 6 09:08:46 PDT 2023


RKSimon accepted this revision.
RKSimon added a comment.

LGTM with one minor



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1275
+                                             InstCombiner::BuilderTy &Builder) {
+  if (IntrID != Intrinsic::bswap && IntrID != Intrinsic::bitreverse)
+    return nullptr;
----------------
Can we just use a static_assert here since its a template arg?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149699/new/

https://reviews.llvm.org/D149699



More information about the llvm-commits mailing list