[PATCH] D147965: [LV] Use VPValue to get expanded value for SCEV step expressions (WIP).

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:2440
 // required to be loop-invariant
 static Value *CreateStepValue(const SCEV *Step, ScalarEvolution &SE,
                               Instruction *InsertBefore,
----------------
Ayal wrote:
> Becomes dead and should be removed?
Removed, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3235
     PHINode *OrigPhi = InductionEntry.first;
     const InductionDescriptor &II = InductionEntry.second;
     PHINode *BCResumeVal = createInductionResumeValue(
----------------
Ayal wrote:
> Suffice to retrieve Step here from II, Plan, and State, and pass it to createInductionResumeValue()?
> Getting the Value expanded from a SCEV possibly deserves wrapping in a common function.
> (Admittedly not saving much.)
Adjusted the arguments, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147965/new/

https://reviews.llvm.org/D147965