[PATCH] D150020: Fix possible self assign issue for DIEValue

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/DIE.h:467
   DIEValue &operator=(const DIEValue &X) {
+    if (&Val == &X.Val)
+      return *this;
----------------
Shouldn't we compare `this` with `&X` instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150020/new/

https://reviews.llvm.org/D150020