[PATCH] D149743: [RISCV][CodeGen] Support Zdinx on RV32 codegen

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D149743#4323730 <https://reviews.llvm.org/D149743#4323730>, @craig.topper wrote:

> In D149743#4323729 <https://reviews.llvm.org/D149743#4323729>, @liaolucy wrote:
>
>> Maybe we shouldn't expand the Pseudo in RISCVExpandPseudoInsts.cpp.
>> It seems that one more MI would get the following error.
>>
>>   llc: /home/liaochunyu/llvm-project/llvm/lib/Target/RISCV/RISCVExpandPseudoInsts.cpp:83: virtual bool (anonymous namespace)::RISCVExpandPseudo::runOnMachineFunction(llvm::MachineFunction &): Assertion `OldSize >= NewSize' failed.
>
> That error means you're missing a `let Size = 8` on the pseudo in tablegen.

Maybe I don’t know you meant by one more MI


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149743/new/

https://reviews.llvm.org/D149743