[PATCH] D149864: [M68k] Add new calling convention M68k_RTD

[Sheng via Phabricator via llvm-commits]

0x59616e added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kExpandPseudo.cpp:264
+      // Default situation for 68000 or adjustment larger than 16 bits
+      // as RTD can only take a 16-bit displacement.
 
----------------
myhsu wrote:
> 0x59616e wrote:
> > myhsu wrote:
> > > RKSimon wrote:
> > > > This comment seems to be for code that doesn't currently exist?
> > > you're right, I'll remove it (and maybe add it back when we have RTD).
> > I don't see any issue in this comment. Doesn't it illustrate what #265 is doing ? Am I missing something ?
> The original comment said that code in this block is the fallback implementation in the absent of RTD instruction. The comment only makes sense if we already have RTD and emit RTD in one of the code path here, which is not the case (yet).
OhOh I saw the comment you were refering to (which is not the comment I'm thinking about). You are right. No question here ;)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149864/new/

https://reviews.llvm.org/D149864