[PATCH] D150009: [AArch64CompressJumpTables] Prevent compression when block alignment is bigger than function alignment.

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 16:33:02 PDT 2023


paulwalker-arm added reviewers: efriedma, david-arm, dmgreen.
paulwalker-arm added a comment.

Not sure of the performance ramifications of this patch but this is a bug fix for something I've hit in real world code.  Looking at `AArch64Subtarget.cpp` has the affected targets as:

  CortexA76
  CortexA77
  CortexA78
  CortexA78C
  CortexR82
  CortexX1
  CortexX1C
  CortexA710
  CortexA715
  CortexX2
  CortexX3
  NeoverseN1
  NeoverseN2
  NeoverseV2
  NeoverseV1

I'm not sure where the value is for having function alignments smaller than loop alignments, so matching them up is a potential easy fix to restore jump table compression. Even if that's done I believe this fix is required to catch other places where alignments can be set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150009/new/

https://reviews.llvm.org/D150009



More information about the llvm-commits mailing list